Skip to content

Add tooltips to bottom up row elements#5346

Merged
kenzieschmoll merged 2 commits into
flutter:masterfrom
kenzieschmoll:tooltips
Mar 3, 2023
Merged

Add tooltips to bottom up row elements#5346
kenzieschmoll merged 2 commits into
flutter:masterfrom
kenzieschmoll:tooltips

Conversation

@kenzieschmoll
Copy link
Copy Markdown
Member

These tooltips will help explain the timing information for the bottom up tree. Work towards #5078

Screenshot 2023-03-02 at 4 24 49 PM

RELEASE_NOTE_EXCEPTION=[too small to call out]

@kenzieschmoll kenzieschmoll requested a review from bkonyi March 3, 2023 00:35
@kenzieschmoll kenzieschmoll requested review from a team and elliette as code owners March 3, 2023 00:35
Copy link
Copy Markdown
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nits

Comment thread packages/devtools_app/lib/src/screens/profiler/cpu_profile_columns.dart Outdated
Comment thread packages/devtools_app/lib/src/screens/profiler/panes/bottom_up.dart Outdated
Comment thread packages/devtools_app/lib/src/screens/profiler/panes/bottom_up.dart Outdated
Comment thread packages/devtools_app/lib/src/screens/profiler/panes/bottom_up.dart Outdated
Comment thread packages/devtools_app/lib/src/screens/profiler/panes/bottom_up.dart Outdated
@kenzieschmoll kenzieschmoll merged commit c57d7f4 into flutter:master Mar 3, 2023
@kenzieschmoll kenzieschmoll deleted the tooltips branch March 3, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants